-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct NewEnterpriseClient deprecation message #2923
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my mistake. Thank you for finding and fixing it.
I signed the CLA. |
Thanks. Just to set your expectations, the primary maintainer is out this week, so there is a good chance this won't get a second review or be merged for a week or so. |
Codecov Report
@@ Coverage Diff @@
## master #2923 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 143 143
Lines 12609 12609
=======================================
Hits 12379 12379
Misses 156 156
Partials 74 74
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @oschwald and @WillAbides !
LGTM.
Merging.
No description provided.